Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 GitHub Actions issues #463

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix 2 GitHub Actions issues #463

merged 2 commits into from
May 9, 2024

Conversation

oldium
Copy link
Contributor

@oldium oldium commented May 6, 2024 •
edited
Loading

There are currently two build failures:

  • build on fedora fails, because the pw_dict.pwd is missing:

    {"payload": "eyJrZXlzIjogW3siYWxnIjogIkVDTVIiLCAiY3J2IjogIlAtNTIxIiwgImtleV9vcHMiOiBbImRlcml2ZUtleSJdLCAia3R5IjogIkVDIiwgIngiOiAiQVJJUHhCUEY5TzR1VnZ2d19IWjg3bW51c0xQd2JLYUNQN0tCSW51azA0Wk43X0JnQUVZRUdjcGZiZXdVU29XU0RkQXpKRnVjSFBmNzVaeWY4Rno5anAybiIsICJ5IjogIkFHeHFtYldLNFdZalN2SzBxbXF6VE9NT0RsTkZLV3BnVUxhYjlueDBSRlNTck4tb1JQazFMUUNQdDhQY3ZWb3BxSlNCVWMwc1hIcW4tVGVKLUtZMW43MmIifSwgeyJhbGciOiAiRVM1MTIiLCAiY3J2IjogIlAtNTIxIiwgImtleV9vcHMiOiBbInZlcmlmeSJdLCAia3R5IjogIkVDIiwgIngiOiAiQVdQRkdLVnZ5azVMX2N6SlZXUVA2b1N6LVhGRmpHeEFRY1NnLXRral9Kcjl0am9wUWFsSUZzRGlndHdkeG1kQm5mY1dVM1pxajZPYl9zd0xwZG5hR2o2NSIsICJ5IjogIkFBSllBLVdsSU5xc210MFZjcE8yRDhkSWRkYmtuMjN2dmVPS0RzOUhIZkNFT1ZkVUtZbUN5QlBUc1p5enlKMmFBc3lDQXNXTFdDWm9mWE1ENm1SWHpmRmQifV19", "protected": "***", "signature": "ASnzLij7bI7GUGqlaa3Qn1W5DGSy84sGmz3KHAj__hMhfRJl1ulnm9GZxOiFKjF3WcdUsT3O3W72jaE6t2iPSzOuAZNc2BIimb8CBCc67hRZjW1IVqat4lKovc175swLDWZFowA2l1_zMHpuGClLRuyr2qQsvbiPqMncVD9AQ1q3xKV_"}/usr/share/cracklib/pw_dict.pwd.gz: No such file or directory

    This can be fixed by installing cracklib-dicts.

  • sometimes the tang_new_random_port function returns already used port:

    + /usr/bin/socat -v -v TCP-LISTEN:42870,reuseaddr,fork 'exec:/usr/libexec/tangd /tmp/tmp.J2NzGGyhIB/db'
2024/05/05 21:54:07 socat[13293] E bind(5, {AF=2 0.0.0.0:42870}, 16): Address already in use

    This can be fixed by letting the system assign the port and then finding it with lsof.

@oldium
Copy link
Contributor Author

oldium commented May 6, 2024

Apparently the Address already in use is not fixed with this (build failed), this needs to be checked more.

@oldium oldium marked this pull request as draft May 6, 2024 20:10
@oldium oldium force-pushed the fix/build branch 3 times, most recently from c1595f2 to 4c3b3ca Compare May 7, 2024 08:36
@oldium
Prevent Address in use error
3e026f1 
Use dynamic listening port (assigned from system), detect it from process
by calling lsof.
@oldium oldium marked this pull request as ready for review May 8, 2024 14:18
@oldium
Copy link
Contributor Author

oldium commented May 8, 2024

Fixed. At the end, the safest is to let the system assign the port and detect it afterwards.

This Pull Request is now ready.

sergio-correia
sergio-correia approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@sergio-correia sergio-correia merged commit 601d0a9 into latchset:master May 9, 2024
12 checks passed
@oldium oldium deleted the fix/build branch July 3, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-correia sergio-correia sergio-correia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oldium @sergio-correia